Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Disable edit transform if item is locked #9575

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Sep 9, 2023

Description

The transform window was still accessible if the scene item was locked.

Motivation and Context

You shouldn't be able to edit the transform of a locked item.

How Has This Been Tested?

Locked/unlocked scene items to make sure the transform window was disabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The transform window was still accessible if the scene item
was locked.
@cg2121 cg2121 added the Bug Fix Non-breaking change which fixes an issue label Sep 9, 2023
@gxalpha gxalpha added the UI/UX Anything to do with changes or additions to UI/UX elements. label Sep 9, 2023
@gxalpha
Copy link
Member

gxalpha commented Sep 9, 2023

I’d want @Warchamp7’s opinion on this, because as-is this is by design. IMO locking the preview should prevent accidental changes, but using the Edit Transform dialog isn’t accidental.

Copy link
Member

@GeorgesStavracas GeorgesStavracas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine from a UI / UX perspective

@PatTheMav
Copy link
Member

I also agree with this change, it mimics learned behaviour from other pro tools where locking a layer usually locks all input fields of associated property widgets and windows as well.

@cg2121 what happens if I lock an item with an associated transform window open?

@cg2121
Copy link
Contributor Author

cg2121 commented Dec 10, 2023

If the window is opened, when the item is locked, the window is updated. This is what the lockSignal does in the code.

@PatTheMav PatTheMav merged commit ef99553 into obsproject:master Dec 10, 2023
14 checks passed
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone Dec 13, 2023
@cg2121 cg2121 deleted the fix-edit-transform-locked branch December 14, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants