Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dl manager rework #86

Merged
merged 5 commits into from
Feb 20, 2022
Merged

Dl manager rework #86

merged 5 commits into from
Feb 20, 2022

Conversation

devrimcavusoglu
Copy link
Member

Closes #83

@devrimcavusoglu devrimcavusoglu marked this pull request as ready for review February 19, 2022 23:07
Sophylax
Sophylax approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@Sophylax Sophylax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accuracy strings updates look out of scope for this PR, but I'm not gonna block a merge because of them. LGTM.

@devrimcavusoglu devrimcavusoglu merged commit 89b8f5a into main Feb 20, 2022
@devrimcavusoglu devrimcavusoglu deleted the dl-manager-rework branch February 20, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sophylax Sophylax Sophylax approved these changes

@cemilcengiz cemilcengiz Awaiting requested review from cemilcengiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor all metrics to use dl_manager internally
2 participants
@devrimcavusoglu @Sophylax