Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError: 'GeometryCollection' object is not subscriptable when slicing COCO #1047

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

Alias-z
Copy link
Contributor

@Alias-z Alias-z commented May 31, 2024

Solution to #1011 by adding a filter for Polygon only

…slicing COCO

Solution to obss#1011 by adding a filter for Polygon only
@fcakyon
Copy link
Collaborator

fcakyon commented Jun 2, 2024

@Alias-z, amazing contribution; thanks a lot!

Can you please fix the styling as described in the readme so that tests are not failing?

@Alias-z
Copy link
Contributor Author

Alias-z commented Jun 2, 2024

Hi, thanks. The linting style has been fixed :)

@fcakyon
Copy link
Collaborator

fcakyon commented Jun 2, 2024

Thanks for your fast response @Alias-z however linting tests are still failing 🥲 Maybe your black isort versions are not matching with the ones required for sahi?

@Alias-z
Copy link
Contributor Author

Alias-z commented Jun 2, 2024

Thanks for your fast response @Alias-z however linting tests are still failing 🥲 Maybe your black isort versions are not matching with the ones required for sahi?

Sorry for the inconvenience. I reinstalled development packages in a new env. And I saw one line was removed after run_code_style format, I hope it works now.

@fcakyon fcakyon added this pull request to the merge queue Jun 2, 2024
Merged via the queue into obss:main with commit 8c07a06 Jun 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants