Add chart to renderer tests

obukhov · Aug 13, 2021 · a530427 · a530427
1 parent de30e16
commit a530427
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/renderer/chart.go b/src/renderer/chart.go
@@ -3,6 +3,7 @@ package renderer
 import (
 	"code.cloudfoundry.org/bytefmt"
 	"encoding/json"
+	"errors"
 	"github.com/hetiansu5/urlquery"
 	"github.com/obukhov/redis-inventory/src/server"
 	"github.com/obukhov/redis-inventory/src/trie"
@@ -19,6 +20,10 @@ func NewChartRendererParams(paramsSerialized string) (ChartRendererParams, error
 		return params, err
 	}
 
+	if params.Port <= 0 {
+		return params, errors.New("port cannot be negative")
+	}
+
 	return params, nil
 }
 

diff --git a/src/renderer/renderer_test.go b/src/renderer/renderer_test.go
@@ -26,6 +26,11 @@ func (suite *RendererTestSuite) TestNewRender() {
 			"",
 			JSONRenderer{},
 		},
+		{
+			"chart",
+			"",
+			ChartRenderer{},
+		},
 	} {
 		suite.Run(t.outputParams, func() {
 			renderer, err := NewRenderer(t.output, t.outputParams, zerolog.Nop())
@@ -49,6 +54,10 @@ func (suite *RendererTestSuite) TestNewRenderWithError() {
 			"json",
 			"padSpaces=asd",
 		},
+		{
+			"chart",
+			"port=-1",
+		},
 	} {
 		suite.Run(t.outputParams, func() {
 			renderer, err := NewRenderer(t.output, t.outputParams, zerolog.Nop())