-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add cli #22
Feat/add cli #22
Conversation
@0x10Ayoub here is my thought on this:
npx app-icon-badge icon.png \
--type=ribbon\
--text=text\
--position=top \
--background-color=#fff \
--color=#000 let me know what you think ? |
@yjose regarding the config file it is optional instead of passing parameters as you mention we let user write them in json file
for passing parameters like i think it will be hard to add multiple icons with different parameters that's why i suggested 3 different why to get user input
|
ok great make sense. to make sure we are in the same path i would recommend making |
just as side note i did start with json file running validation with zod |
What does this do?
How did you test this?Locally manually with build and npm link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
hi @SihamBen @yjose I need your feedback, is this the right path to walk in?
and also for managing the packages i think about using https://www.npmjs.com/package/lerna and keep the cli separate from the app-icon-badge
what does this do