Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError: No module named server_environment_files #89

Closed
dreispt opened this issue Dec 4, 2014 · 11 comments
Closed

ImportError: No module named server_environment_files #89

dreispt opened this issue Dec 4, 2014 · 11 comments
Milestone

Comments

@dreispt
Copy link
Member

dreispt commented Dec 4, 2014

I stumbled upon this when trying the scaffold command: odoo/odoo#4034

Looking at the server_environment module, is has a dependency on a server_environment_files module that doesn't exist: https://github.com/OCA/server-tools/blob/8.0/server_environment/__openerp__.py#L25

Is this doomed to error or am I missing something?

@guewen
Copy link
Member

guewen commented Dec 4, 2014

It appears that the module has been renamed to server_environment_files_sample https://github.com/OCA/server-tools/tree/8.0/server_environment_files_sample.
However, server_environment really depends on a module server_environment_files that is usually specific to the customer because it contains the specific customization files (the supposed workflow is to copy server_environment_files_sample in a local path and rename it to server_environment_files).
I can think of 2 solutions:

  • rename server_environment_files_sample to server_environment_files
  • remove the "hard" dependency in server_environment and handle the exceptions inside the module when server_environment_files is missing.

@pedrobaeza
Copy link
Member

I think second one is better.

@dreispt
Copy link
Member Author

dreispt commented Dec 4, 2014

I agree with Pedro.

dreispt added a commit to dreispt/server-tools that referenced this issue Dec 10, 2014
Quick fix to make `./odoo.py help` work without errors when the
server_environment_files modules does not exist.
Fixes OCA#89.
@dreispt
Copy link
Member Author

dreispt commented Dec 10, 2014

This is breaks my work environment, so I made #93, a quick fix that works for me.

@az-iB
Copy link

az-iB commented Jan 23, 2015

install python-ldap 2.4.19 it worked for me :
https://pypi.python.org/pypi/python-ldap/2.4.19#downloads

@dreispt
Copy link
Member Author

dreispt commented Jan 23, 2015

I have python-ldap installed and am even using it. That can't be the cause.

@petrus-v
Copy link
Contributor

Hi,

As this issue is open, I let a message here, mail_environment modue also has a dependency on a server_environment_files module that doesn't exist: https://github.com/OCA/server-tools/blob/8.0/mail_environment/__openerp__.py#L65

@max3903 max3903 added this to the 8.0 milestone Feb 17, 2015
clonedagain pushed a commit to numerigraphe/server-tools that referenced this issue Mar 16, 2015
@gurneyalex
Copy link
Member

note that this should no longer be breaking runbot builds.

@dreispt dreispt modified the milestones: 7.0, 8.0 Aug 11, 2015
@clonedagain
Copy link

It looks like this is fixed, can you confirm please?

@KaloyanNaumov
Copy link

same applies to the "mail_environment" module. It's the same dependency definition.

@yajo
Copy link
Member

yajo commented Dec 23, 2016

Please see fix in #666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants