fix: Fix admin pages for old games without classes too

[faucomte97]

This change is 

[dionizh]

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)

---

aimmo/admin.py, line 22 at r1 (raw file):

    def school(self, obj):
        if obj.game_class:

Should this be if obj and obj.game_class to be safer?

[faucomte97]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dionizh)

---

aimmo/admin.py, line 22 at r1 (raw file):

Previously, dionizh (Dioni Zhong) wrote…

Should this be if obj and obj.game_class to be safer?

I think checking if obj isn't needed as obj refers to the object that is listed in the admin page so obj shouldn't ever be None.
I can still add the check though if you want?

[dionizh]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)

---

aimmo/admin.py, line 22 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

I think checking if obj isn't needed as obj refers to the object that is listed in the admin page so obj shouldn't ever be None.
I can still add the check though if you want?

Yea looking in context the others are not doing it too. All good 🙃

[dionizh]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

[codecov]

Codecov Report

Merging #1555 (d32578c) into development (7ebee03) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #1555      +/-   ##
===============================================
- Coverage        67.19%   67.15%   -0.05%     
===============================================
  Files              160      160              
  Lines             3268     3270       +2     
  Branches           231      231              
===============================================
  Hits              2196     2196              
- Misses            1044     1046       +2     
  Partials            28       28              

Impacted Files	Coverage Δ
aimmo/admin.py	74.19% <0.00%> (-5.12%)	⬇️