This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Added our own test suite for the django tests and removed the django-… #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setuptest dependency.
riaJha97
reviewed
Jul 20, 2018
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NiallEgan)
test_utils/test_suite.py, line 26 at r1 (raw file):
self.test_runner.setup_test_environment() self.old_config = self.test_runner.setup_databases()
why is it old_config
NiallEgan
commented
Jul 20, 2018
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @CelineBoudier and @riaJha97)
test_utils/test_suite.py, line 26 at r1 (raw file):
Previously, CelineBoudier (Celine Boudier) wrote…
why is it old_config
Renamed to something clearer.
CelineBoudier
approved these changes
Jul 20, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
OlafSzmidt
pushed a commit
that referenced
this pull request
Jul 25, 2018
* Logs logic * Send logs from worker minor change * Updated test * Wrote some test cases for avatar logs * Minor refactoring (splitting logs and actions apart) * Merge remote-tracking branch 'origin/send_logs_from_worker' into save_logs * Catch worker not ready edge case * Fix #632 and master conflicts * Minor refactoring * prints for testing * Merge branch 'save_logs' of https://github.com/ocadotechnology/aimmo into save_logs * Fixed some broken tests * Merge branch 'save_logs' of https://github.com/ocadotechnology/aimmo into save_logs * Merge branch 'test_logs' into save_logs * Added some test cases for logs that check whether the logs are received successfully using the turn manager and the worker. * Added another file that tests logs becuase I'm not sure which one is correct * Added our own test suite for the django tests and removed the django-setuptest dependency. * Deleted other test_logs file * Changed logger level back to INFO * Pep8 stuff * variable rename * Fixed deprecation warnings for Django 1.10 (#682) * String arguments deprecated in 1.10 * replaced middleware_classes with middleware as it is deprecated in 1.10 * Merge pull request #679 from ocadotechnology/remove_setuptest Added our own test suite for the django tests and removed the django-… * Minor PEP8 changes (#672) * Revert "Work on docs" This reverts commit b667e4c3f91b24f37a6dd8d2980410314336473d. * Added tests for avatars with no workers and improved docs. * PEP8 stuff PEP8 stuff PEP8 stuff * Minor PEP8 changes * Minor PEP8 changes * Logs logic * Wrote some test cases for avatar logs * Minor refactoring (splitting logs and actions apart) * Catch worker not ready edge case * Minor refactoring * prints for testing * Fixed some broken tests * Added some test cases for logs that check whether the logs are received successfully using the turn manager and the worker. * Added another file that tests logs becuase I'm not sure which one is correct * Deleted other test_logs file * Changed logger level back to INFO * Pep8 stuff * Merge remote-tracking branch 'origin/save_logs' into save_logs * Add changes as requested * Change exception levels to suit outer function * Reflect handle_turn as same method declaration * Single responsibility principle... kind of 🤷♀️ * Refactor method name * Catch exceptions instead * Pull request changes * Use attribute setters * Add the DummyAvatarManager back in * Fix too many blank lines in avatar_wrapper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…setuptest dependency. Fixes #678.
This change is