Fix local non -k mode

[OlafSzmidt]

Fixes #694. Please read the issue if you're reviewing.

---

This change is 

[NiallEgan]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @OlafSzmidt)

---

aimmo/game_renderer.py, line 53 at r1 (raw file):

def _connection_on_k8s_mode(game_port):

Maybe a comment to explain why this function works? Could be a bit confusing in a few months time

[OlafSzmidt]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @OlafSzmidt)

---

aimmo/game_renderer.py, line 53 at r1 (raw file):

Previously, NiallEgan (Niall Egan) wrote…

Maybe a comment to explain why this function works? Could be a bit confusing in a few months time

@mrniket told me not to yesterday, I'm for docstringing this too, it's quite a complicated method to understand in terms of how the architecture works.

@mrniket ???

[mrniket]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @NiallEgan and @OlafSzmidt)

---

aimmo/game_renderer.py, line 53 at r1 (raw file):

Previously, OlafSzmidt (Olaf Szmidt) wrote…

@mrniket told me not to yesterday, I'm for docstringing this too, it's quite a complicated method to understand in terms of how the architecture works.

@mrniket ???

I would prefer making the code "clean" over comments. Comments are more easily forgotten about when you are modifying this code later, so are more likely to be outdated. I would argue that in this case, the function name contains the same information a comment would have done but via code.

For more information I recommend having a quick look at these links:

• https://gist.github.com/wojteklu/73c6914cc446146b8b533c0988cf8d29
• https://engineering.videoblocks.com/these-four-clean-code-tips-will-dramatically-improve-your-engineering-teams-productivity-b5bd121dd150

[NiallEgan]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @OlafSzmidt)

---

aimmo/game_renderer.py, line 53 at r1 (raw file):

Previously, mrniket (Niket Shah) wrote…

I would prefer making the code "clean" over comments. Comments are more easily forgotten about when you are modifying this code later, so are more likely to be outdated. I would argue that in this case, the function name contains the same information a comment would have done but via code.

For more information I recommend having a quick look at these links:

• https://gist.github.com/wojteklu/73c6914cc446146b8b533c0988cf8d29
• https://engineering.videoblocks.com/these-four-clean-code-tips-will-dramatically-improve-your-engineering-teams-productivity-b5bd121dd150

Ok, agreed that a comment won't add much. I think we could do with a better way to check if we are using k8s, but that is probably outside the scope of this PR.

[NiallEgan]

Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

[OlafSzmidt]

Reviewable status: complete! all files reviewed, all discussions resolved

---

aimmo/game_renderer.py, line 53 at r1 (raw file):

Ok, agreed that a comment won't add much. I think we could do with a better way to check if we are using k8s, but that is probably outside the scope of this PR.

I agree it's not ideal and intuitive, but changes would require both the front-end and backend to be altered.