This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1246: BBQ will not backup empty table if current newest backup … #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of given table is not empty and lastModification time is newer than date of newest backup
radkomateusz
requested review from
marcin-kolda,
przemyslaw-jasinski,
jarekdrabek,
MZatorski and
marek-tabor
Pull Request Test Coverage Report for Build 1115
💛 - Coveralls |
MZatorski
suggested changes
Apr 15, 2019
| @@ -45,6 +45,9 @@ def __is_table_backup_up_to_date(self, big_query_table_metadata, last_backup): | |||
| ) | |||
| if source_table_last_modified_time > last_backup.last_modified: | |||
| logging.info("Backup time is older than table metadata") | |||
| if big_query_table_metadata.is_empty() and last_backup.numBytes > 0: | |||
There was a problem hiding this comment.
I wonder if this should be separate method that returns True/False rather than additional "if" deep in the tree.
I think this answers different question then "is_table_backup_up_to_date"
There was a problem hiding this comment.
I moved it to to main method. And refactored it a little.
…ness. Adding test: Should make backup if source table is empty and existing backup is also empty (eg. schema change but without adding any data).
MZatorski
approved these changes
Apr 15, 2019
marcin-kolda
approved these changes
Apr 15, 2019
przemyslaw-jasinski
pushed a commit
that referenced
this pull request
Apr 23, 2019
YACHT-1246: BBQ will not backup empty table if current newest backup …
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of given table is not empty and lastModification time is newer than date of newest backup