This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1259 Add exception handling for on-demand table backup, code re… #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor, test refactor
| if big_query_table_metadata.is_empty(): | ||
| logging.info('This table is empty') | ||
| return False, "This table is empty" |
There was a problem hiding this comment.
It's tricky, but there are cases, when even if table is empty, we want to copy it.
Not returning anything in previous implementation was intended.
radkomateusz
suggested changes
Sep 13, 2019
| @@ -1,5 +1,6 @@ | |||
| import logging | |||
| from abc import abstractmethod | |||
| from src.commons.exceptions import ParameterValidationException, NotFoundException | |||
There was a problem hiding this comment.
is this import used somewhere in this file?
radkomateusz
suggested changes
Sep 13, 2019
Pull Request Test Coverage Report for Build 1255
💛 - Coveralls |
radkomateusz
approved these changes
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…factor, test refactor