This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
NON-JIRA: Make backups when table has backup made after source table … #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…last modification but there is size mismatch between source and backup table. Empty source table corner case still should no be backed up if non empty backup exists.
radkomateusz
requested review from
marcin-kolda,
przemyslaw-jasinski,
jarekdrabek,
MZatorski and
marek-tabor
Pull Request Test Coverage Report for Build 1258
💛 - Coveralls |
jarekdrabek
approved these changes
Dec 9, 2019
marcin-kolda
reviewed
Dec 9, 2019
|
|
||
| source_table_num_bytes = big_query_table_metadata.table_size_in_bytes() | ||
| if source_table_num_bytes != last_backup.numBytes: | ||
| logging.info("Backup size is different than source. " |
There was a problem hiding this comment.
As in theory this should never happen, maybe we should log also source/backup last update time, so it will be easier to analyse based on logs?
There was a problem hiding this comment.
It's already logged at the begining of __is_table_backup_up_to_date method.
So informations are already in place.
marcin-kolda
approved these changes
Dec 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…last modification but there is size mismatch between source and backup table.
Empty source table corner case still should no be backed up if non empty backup exists.