This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1009: copy job now handles insert job duplicates #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-kolda
requested review from
przemyslaw-jasinski,
radkomateusz and
jarekdrabek
Pull Request Test Coverage Report for Build 579
💛 - Coveralls |
| @@ -38,9 +41,14 @@ def run_copy_job_request(copy_job_request): | |||
|
|
|||
| @staticmethod | |||
| @retry(Exception, tries=6, delay=2, backoff=2) | |||
| def __schedule(source_big_query_table, target_big_query_table): | |||
| def __schedule(source_big_query_table, target_big_query_table, job_id): | |||
| logging.info("Scheduling job ID: " + job_id) | |||
| job_data = { | |||
| "projectId": source_big_query_table.get_project_id(), | |||
There was a problem hiding this comment.
does this line decides about from which project copy job quota is used? why source then?
how it is connected with jobReference.projectId field where target project id is used?
There was a problem hiding this comment.
Hm... projectId doesn't exist in REST API. I remember we planned to remove it :), so I'll remove it.
jarekdrabek
deleted the
YACHT-1009_copy_job_should_handle_duplicated_job_id
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.