This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1029: Introducing sli table recreation filter - it filters out … #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tables which was recreated (the current creationTime from bigquery.tables.get is newest that creationTime stored in last GCP census snapshot). Unit tests for filters and adding more unit tests for x days sli service which examine behavior for different results returned from filters.
Pull Request Test Coverage Report for Build 690
💛 - Coveralls |
jarekdrabek
reviewed
Sep 26, 2018
jarekdrabek
reviewed
Sep 26, 2018
…lasses do. Refactor to common predicate api -> changes in uni tests.
radkomateusz
requested review from
marcin-kolda,
jarekdrabek,
MZatorski and
przemyslaw-jasinski
jarekdrabek
approved these changes
Sep 26, 2018
przemyslaw-jasinski
approved these changes
Sep 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tables which was recreated (the current creationTime from bigquery.tables.get is newest that creationTime stored in last GCP census snapshot).
Unit tests for filters and adding more unit tests for x days sli service which examine behavior for different results returned from filters.