This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
YACHT-1092: Passing create/write dispostion via RestorationJob for As… #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yncRestoreService (as it is common for whole restore). Updating paths in app.yaml. Updating restore status to show write/create disposition. Passing RestorationJob as object in parameters to avoid unnecessary calls to Datastore.
Pull Request Test Coverage Report for Build 819
💛 - Coveralls |
przemyslaw-jasinski
approved these changes
Nov 15, 2018
| @@ -24,7 +24,10 @@ def restore(self, restoration_job_id, project_id, dataset_id, | |||
| max_partition_days) | |||
|
|
|||
| try: | |||
| RestorationJob.create(restoration_job_id) | |||
| restoration_job_key = RestorationJob.create( | |||
| restoration_job_id, | |||
There was a problem hiding this comment.
Pass name parameter in all of those or none (e.g. create_disposition=)
There was a problem hiding this comment.
I will do in next pull request when I will edit whole dataset restore service
jarekdrabek
approved these changes
Nov 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…yncRestoreService (as it is common for whole restore). Updating paths in app.yaml.
Updating restore status to show write/create disposition.
Passing RestorationJob as object in parameters to avoid unnecessary calls to Datastore.