Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

Yacht 1093 #92

Merged
merged 33 commits into from
Nov 26, 2018
Merged

Yacht 1093 #92

merged 33 commits into from
Nov 26, 2018

Conversation

radkomateusz
Copy link
Contributor

No description provided.

YACHT-1094: BackupListRestore refactor
YACHT-1094: BackupListRestoreHandler small refactor
…reate/write disposition and target project ID via UI. Dataset restore UI improvements.
…ataset are correctly taken when checkbox is unchecked.
…ataset are correctly taken when checkbox is unchecked.
…port checking locations of target dataset from target project passed by user.
…restore, when no target project id is specified, restores into source.
…restore, when no target project id is specified, restores into source.
@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 875

  • 123 of 125 (98.4%) changed or added relevant lines in 10 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 83.445%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/restore/dataset/dataset_restore_service.py 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
src/commons/big_query/copy_job_async/copy_job_result.py 1 97.78%
src/backup/after_backup_action_handler.py 5 89.55%
Totals Coverage Status
Change from base Build 834: 0.1%
Covered Lines: 2490
Relevant Lines: 2984

💛 - Coveralls

# restoration_project_id - project into which data will be restored during restoration process
restoration_project_id: 'restoration-storage-project-id'
# default_restoration_project_id - project into which data will be restored by default during restoration process
default_restoration_project_id: 'default-restoration-storage-project-id'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field should be commented by default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in new branch YACHT-1093-3

Yacht-1099: Update single table restore method
@marcin-kolda marcin-kolda merged commit da35aac into master Nov 26, 2018
@marcin-kolda marcin-kolda deleted the YACHT-1093 branch February 1, 2019 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants