Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visualization-bar): add new components #546

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

charlieTheBotDev
Copy link
Contributor

@charlieTheBotDev charlieTheBotDev commented Sep 13, 2019

Description

Adds:

  • VisualizationBar
  • ProgressBar (new class with feature flag)

Motivation and Context

The existing progress bar is very basic and the API doesn't allow for much flexibility. The current ProgressBar api makes more sense as a different component (VisualizationBar) with improved visuals (i.e. showing values on bars, labels under bars etc.)

A new ProgressBar that provides a specific API with 'done', 'in progress' and 'plan' numbers made more sense in this case.

How Has This Been Tested?

Added unit tests to under-the-hood StatusBar (used by both new components) and the new wrappers

Screenshots (if appropriate):

Screenshot 2019-09-18 at 14 39 43

Checklist:

  • I have added a tag to this pull request that indicates the impact of the change (patch, minor or major)
  • My code follows the code style of this project.
  • I have updated the documentation accordingly. (This includes updating the changelog).
  • I have read the CONTRIBUTING document. (Last updated 16 Aug 2019)
  • All my changes are covered by tests.
  • This request is ready to review and merge

@charlieTheBotDev charlieTheBotDev force-pushed the NO-ISSUE_visualization-bar branch 4 times, most recently from ac62e5a to 4106fe6 Compare September 18, 2019 13:25
@coveralls
Copy link

coveralls commented Sep 18, 2019

Coverage Status

Coverage increased (+0.3%) to 69.681% when pulling 079dc75 on NO-ISSUE_visualization-bar into 4b2b9fb on develop.

@charlieTheBotDev charlieTheBotDev changed the title WIP feat(visualization-bar): add new components feat(visualization-bar): add new components Sep 18, 2019
@charlieTheBotDev charlieTheBotDev changed the base branch from master to develop September 18, 2019 13:36
Adds:
- VisualizationBar
- ProgressBar (feature flags)
@charlieTheBotDev charlieTheBotDev mentioned this pull request Sep 18, 2019
@charlieTheBotDev charlieTheBotDev merged commit df30f38 into develop Sep 18, 2019
@charlieTheBotDev charlieTheBotDev deleted the NO-ISSUE_visualization-bar branch September 18, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants