fix regression with unit qualification #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ocaml-community#428 The change in ocaml-community#418 introduced a regression if a `Unit` module in scope does not have a `()` constructor in it. This switches to the more explicit `Stdlib.Unit.()` path.
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Apr 21, 2023
CHANGES: * Fix regression with unit qualification when a `Unit` module is in scope with no `()` constructor (ocaml-community/utop#429, fixes ocaml-community/utop#428, @emillon) * emacs: add completion-at-point implementation (ocaml-community/utop#406, fixes ocaml-community/utop#261, @j-shilling)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428
The change in #418 introduced a regression if a
Unitmodule in scope does not have a()constructor in it.This switches to the more explicit
Stdlib.Unit.()path.