Doesn't compile under 4.06.0+trunk due to safe-string default

[hcarty]

Using opam 1.2.2 and 4.06.0+trunk (safe-string enabled by default):

#=== ERROR while installing zed.1.5 ===========================================#
# opam-version 1.2.2
# os           linux
# command      jbuilder build -p zed -j 4
# path         /home/hcarty/.opam/4.06.0+trunk/build/zed.1.5
# compiler     4.06.0+trunk
# exit-code    1
# env-file     /home/hcarty/.opam/4.06.0+trunk/build/zed.1.5/zed-16785-0edee0.env
# stdout-file  /home/hcarty/.opam/4.06.0+trunk/build/zed.1.5/zed-16785-0edee0.out
# stderr-file  /home/hcarty/.opam/4.06.0+trunk/build/zed.1.5/zed-16785-0edee0.err
### stderr ###
# Error: This expression has type bytes but an expression was expected of type
# [...]
# (cd _build/default && /home/hcarty/.opam/4.06.0+trunk/bin/ocamlopt.opt -w -40 -g -I /home/hcarty/.opam/4.06.0+trunk/lib/bytes -I /home/hcarty/.opam/4.06.0+trunk/lib/camomile -I /home/hcarty/.opam/4.06.0+trunk/lib/ocaml -I /home/hcarty/.opam/4.06.0+trunk/lib/react -no-alias-deps -I src -o src/zed_utf8.cmx -c -impl src/zed_utf8.ml)
# File "src/zed_utf8.ml", line 303, characters 26-29:
# Error: This expression has type bytes but an expression was expected of type
#          string
#       ocamlc src/zed_rope.{cmo,cmt} (exit 2)
# (cd _build/default && /home/hcarty/.opam/4.06.0+trunk/bin/ocamlc.opt -w -40 -g -bin-annot -I /home/hcarty/.opam/4.06.0+trunk/lib/bytes -I /home/hcarty/.opam/4.06.0+trunk/lib/camomile -I /home/hcarty/.opam/4.06.0+trunk/lib/ocaml -I /home/hcarty/.opam/4.06.0+trunk/lib/react -no-alias-deps -I src -o src/zed_rope.cmo -c -impl src/zed_rope.ml)
# File "src/zed_rope.ml", line 541, characters 13-91:
# Error: This expression has type bytes but an expression was expected of type
#          Zed_utf8.t = string

[hcarty]

In particular, this blocks installation of utop.

[Fourchaux]

Same pb with:

opam  2.0.0~beta4 | linux/x86_64 | ocaml 4.06.0+flambda 

[cfcs]

#8

[pmetzger]

I just hit this. The fact that it blocks the install of utop is kind of bad, it means I can't really upgrade to 4.06.

Does anyone know what needs to be done to patch this?

[cfcs]

@pmetzger see my link to @rgrinberg's PR above.

[rgrinberg]

@pmetzger everything that "needs to be done" is finished. We just need for the releases to hit opam-repository.

[pmetzger]

@cfcs I didn't notice that the "#8" was a link. :)

Apologies!

[pmetzger]

Is this problem still active or can we close it? @diml?

[hcarty]

This is OK now! Thank you for the nudge @pmetzger. Closing.