Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hexadecimal base int #223

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Hexadecimal base int #223

merged 1 commit into from
Jun 8, 2022

Conversation

paulpatault
Copy link
Contributor

Added test relative to past error #194

pascutto
pascutto approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@pascutto pascutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Can you keep only the last commit in this PR so we can handle the warnings separately?

@paulpatault
Copy link
Contributor Author

LGTM, thanks! Can you keep only the last commit in this PR so we can handle the warnings separately?

Done 👍

@pascutto pascutto linked an issue Jun 8, 2022 that may be closed by this pull request
integer literal in hexadecimal not accepted #194
Closed
@pascutto pascutto merged commit 538a780 into ocaml-gospel:main Jun 8, 2022
@paulpatault paulpatault deleted the hexadecimal-base-int branch June 8, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascutto pascutto pascutto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integer literal in hexadecimal not accepted
2 participants
@paulpatault @pascutto