Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #323

Merged
merged 22 commits into from
Sep 8, 2023
Merged

Update documentation #323

merged 22 commits into from
Sep 8, 2023

Conversation

shym
Copy link
Contributor

@shym shym commented Sep 1, 2023

This PR updates the documentation. It is based on #253, as it changes the fixed version of the documentation, obviously.

It does a large reorganisation of the language reference part.
It addresses the comments in #57 that were not yet taken into account.

Closes #322

It should contribute to close #293

In particular, use "pieces" (of information, ...) rather than "bits", to
avoid the ambiguity
While at it, sort keywords alphabetically
Clauses are expected in a fixed order in the grammar
The content of that section is not really a specification (the grammar
is partial and it does not say enough about the semantics) so use a more
generic title
Extract from "Locations" the syntax information (ie @) that new users
would care about first
Rename "Terms and formulae" subsection into "Expressions"
Describe in more details the differences between Gospel and OCaml
expressions
Remove formal grammars as they are not really up-to-date
pages/faq.md is never rendered (and it is pretty empty anyway)
Reformulate a few sentences and code blocks in the documentation so that
it is using valid syntax and can be checked accordingly
@shym
Copy link
Contributor Author

shym commented Sep 7, 2023

Latest updates to that PR bring among other things a build of the documentation as an CI artifact, so that the actual rendering can be checked locally (it requires a web server, as docusaurus URLs are not real paths) before merging to main and actually deploying it.

Copy link
Contributor

@n-osborne n-osborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rework of the documentation.

Just one tiny remark:
As all the content is now in the sidebare, maybe annouce the page about gospel standard library in the welcome page.

@shym shym added documentation no-changelog-needed This PR does not require a changelog entry labels Sep 8, 2023
In the Gospel documentation, maybe it is not useful to state that we are
talking about Gospel...
Move the tips to the reference sections where they apply
@shym
Copy link
Contributor Author

shym commented Sep 8, 2023

Latest update: I added the suggested link from the Welcome to Stdlib, and dropped the Tips page, after moving the tips it contained to the relevant sections.

@shym shym merged commit 984b441 into ocaml-gospel:main Sep 8, 2023
4 checks passed
@shym shym deleted the documentation-updates branch September 8, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation no-changelog-needed This PR does not require a changelog entry
Projects
None yet
2 participants