Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a generic pp_gen pretty-printer for error messages #326

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

shym
Copy link
Contributor

@shym shym commented Sep 7, 2023

Generalise the error pretty-printer so that its logic to fix the locations (due to preprocessing messing them up) can be reused directly by other tools using gospel as a library

@shym shym changed the title Introduce a generic pp_fix pretty-printer for error messages Introduce a generic pp_gen pretty-printer for error messages Sep 14, 2023
@shym
Copy link
Contributor Author

shym commented Sep 14, 2023

I rebased and changed the name of the new generic function, as pp_fix was too bound to the fact that it is fixing locations, while it also opens the way to displaying warnings.

@n-osborne
Copy link
Contributor

n-osborne commented Sep 15, 2023

This deserves an entry in the changelog, but I agree that pp_gen is a better name than pp_fix.

…sages

Generalise the error pretty-printer so that its logic to fix the
locations (due to preprocessing messing them up) and to quote the source
code can be reused directly by other tools using gospel as a library
@shym shym merged commit 6f877b3 into ocaml-gospel:main Sep 15, 2023
2 checks passed
@shym shym deleted the pp_fix branch September 15, 2023 09:47
@shym
Copy link
Contributor Author

shym commented Sep 15, 2023

I added a CHANGES entry and, as CI was happy, merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants