Make with necessary when declaring type invariants.
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
no-nameless-invariant
branch
from
9c99e95
to
f3bb4e2
Compare
shym
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
LGTM, well done!
It requires a round of dune runtest --auto-promote or two before merging.
A small suggestion: it might be nicer in src/upretty_printer.ml to reset Option with a module Option = Stdlib.Option just after the opens, since we don’t really need Opprintast.Option anyway.
n-osborne
force-pushed
the
no-nameless-invariant
branch
2 times, most recently
from
91bddea
to
8940ff1
Compare
n-osborne
force-pushed
the
no-nameless-invariant
branch
from
8940ff1
to
8a5fd30
Compare
|
Thanks. |
shym
approved these changes
Dec 18, 2023
n-osborne
force-pushed
the
no-nameless-invariant
branch
from
4c9cf1a
to
4515ca4
Compare
|
CI failure is unrelated. |
n-osborne
added a commit
to n-osborne/gospel
that referenced
this pull request
Jan 10, 2024
This changes completes those made in a previous PR (ocaml-gospel#372). It contains the actual change in the typed ast and hence is expected to break tools relying on the changed parts.
n-osborne
added a commit
to n-osborne/gospel
that referenced
this pull request
Jan 10, 2024
This commit completes the changes made in a previous PR (ocaml-gospel#372). It contains the actual change in the typed ast and hence is expected to break tools relying on the changed parts.
n-osborne
added a commit
to n-osborne/gospel
that referenced
this pull request
Jan 10, 2024
This commit completes the changes made in a previous PR (ocaml-gospel#372). It contains the actual change in the typed ast and hence is expected to break tools relying on the changed parts.
n-osborne
added a commit
to n-osborne/gospel
that referenced
this pull request
Jan 10, 2024
This commit completes the changes made in a previous PR (ocaml-gospel#372). It contains the actual change in the typed ast and hence is expected to break tools relying on the changed parts.
mrjazzybread
pushed a commit
to mrjazzybread/gospel
that referenced
this pull request
Apr 5, 2024
This commit completes the changes made in a previous PR (ocaml-gospel#372). It contains the actual change in the typed ast and hence is expected to break tools relying on the changed parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369