Change ls_equal implementation
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
ls_equality
branch
from
8d29614
to
712e8a1
Compare
shym
approved these changes
Jan 29, 2024
Move from physical equality to equality on indentifier so that equality holds accross gospel runs.
n-osborne
force-pushed
the
ls_equality
branch
from
712e8a1
to
e2de346
Compare
|
Agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to move from physical equality to equality of the identifiers.
This will be needed as we plan to make gospel type checker modular (see #377): different files will be typed by different runs of the gospel program and physical equality won't hold between these runs.