Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeron test revision #367

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Ephemeron test revision #367

merged 4 commits into from
Jun 15, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jun 13, 2023

With #365 merged this PR offers a similar revision of the Ephemeron tests, where we have observed excessive shrinking runs, primarily under Cygwin where they have contributed to workflow timeouts.

Similarly to the Weak module, Ephemerons depend on the GC heap state - and so we avoid Lin tests that compare the state of potentially widely different heap states in favor of STM tests, taking extra care

  • to Gc.full_major before starting the parallel test,
  • to run a Gc.minor in between, and
  • to actually use boxed types

With luck, we should hopefully see fewer Cygwin timeouts due to excessive Weak and Ephemeron shrinking runs

@jmid
Copy link
Collaborator Author

jmid commented Jun 15, 2023

CI summary for 67465a2:

  • Cygwin part 1, 5.1~alpha2 and trunk 5.2 timeouts with +1000sec runs of Domain.spawn/join - atomic, domain_spawntree, Lin Atomic, Bigarray, and Bytes
  • Cygwin part 1, trunk 5.2 timeout with the above + a 2795.8s Lin Out_channel shrinking run
  • Windows bytecode trunk 5.2 and Windows 5.1~alpha2 timeout on threadomain [ocaml5-issue] Windows failures on threadomain #203

@jmid
Copy link
Collaborator Author

jmid commented Jun 15, 2023

CI summary for 4907ffa:

@jmid
Copy link
Collaborator Author

jmid commented Jun 15, 2023

I'll merge as none of the above are related to the Ephemeron test changes

@jmid jmid merged commit 79ca3de into main Jun 15, 2023
@jmid jmid deleted the ephemeron-test-revision branch June 15, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant