This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
systhreads: do st_thread_id after initializing the thread descriptor #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caml_c_thread_register
|
This LGTM. The |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…_c_thread_register systhreads: do st_thread_id after initializing the thread descriptor
c-cube
pushed a commit
to c-cube/ocaml
that referenced
this pull request
Feb 3, 2022
…_c_thread_register systhreads: do st_thread_id after initializing the thread descriptor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the issue found at #528 (
linux-O0build.)The mistake is pretty easy to spot, the thread id was set before initializing the related thread descriptor.
I'm not quite sure why this is only showing up in the
O0build, I would guess some checks or accesses are elided during a following optimization pass.