Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_sites_module creates issues when used with multiple packages #4415

Closed
toots opened this issue Mar 30, 2021 · 1 comment
Closed

generate_sites_module creates issues when used with multiple packages #4415

toots opened this issue Mar 30, 2021 · 1 comment
Assignees
Labels

Comments

@toots
Copy link
Contributor

toots commented Mar 30, 2021

dune-project:

(lang dune 2.8)
(using dune_site 0.1)

(package
  (name foo)
  (sites (share libs)))

(package
  (name foo.bar))

dune:

(generate_sites_module
 (module foo_sites)
 (sites foo))

(library
 (name foo)
 (package foo)
 (modules foo_sites))

Then:

% dune build -p foo.bar
File "dune", line 3, characters 8-11:
3 |  (sites foo))
            ^^^
Error: dune_site used outside a package
@bobot
Copy link
Collaborator

bobot commented Mar 30, 2021

It should indeed not be failing, an error in the dune_lang parser I believe.

However I'm surprised that Dune accepts foo.bar as a package name. (EDIT: IT will be for Dune3: (* DUNE3 verify no dots or spaces *))

@bobot bobot added the bug label Mar 30, 2021
bobot added a commit to bobot/jbuilder that referenced this issue May 21, 2021
bobot added a commit to bobot/jbuilder that referenced this issue May 25, 2021
        Fixes ocaml#4415

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue May 28, 2021
        Fixes ocaml#4415

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit that referenced this issue Jun 9, 2021
        Fixes #4415

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue Jun 14, 2021
        Fixes ocaml#4415

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue Jun 14, 2021
        Fixes ocaml#4415

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue Jun 15, 2021
        Fixes ocaml#4415

Signed-off-by: François Bobot <francois.bobot@cea.fr>
bobot added a commit to bobot/jbuilder that referenced this issue Jun 24, 2021
        Fixes ocaml#4415

Signed-off-by: François Bobot <francois.bobot@cea.fr>
@bobot bobot closed this as completed in 24ca271 Jun 24, 2021
ejgallego added a commit to ejgallego/opam-repository that referenced this issue Jun 29, 2021
…ator, dune-private-libs, dune and dune-build-info (2.9.0)

CHANGES:

- Add `(enabled_if ...)` to `(mdx ...)` (ocaml/dune#4434, @emillon)

- Add support for instrumentation dependencies (ocaml/dune#4210, fixes ocaml/dune#3983, @nojb)

- Add the possibility to use `locks` with the cram tests stanza (ocaml/dune#4480, @voodoos)

- Allow to set up merlin in a variant of the default context
  (ocaml/dune#4145, @TheLortex, @voodoos)

- Add `(package ...)` to `(mdx ...)` (ocaml/dune#4691, fixes ocaml/dune#3756, @emillon)

- Handle renaming of `coq.kernel` library to `coq-core.kernel` in Coq 8.14 (ocaml/dune#4713, @proux01)

- Fix generation of merlin configuration when using `(include_subdirs
  unqualified)` on Windows (ocaml/dune#4745, @nojb)

- Fix bug for the install of Coq native files when using `(include_subdirs qualified)`
  (ocaml/dune#4753, @ejgallego)

- Allow users to specify install target directories for `doc` and
  `etc` sections. We add new options `--docdir` and `--etcdir` to both
  Dune's configure and `dune install` command. (ocaml/dune#4744, fixes ocaml/dune#4723,
  @ejgallego, thanks to @JasonGross for reporting this issue)

- Fix issue where Dune would ignore `(env ... (coq (flags ...)))`
  declarations appearing in `dune` files (ocaml/dune#4749, fixes ocaml/dune#4566, @ejgallego @rgrinberg)

- Disable some warnings on Coq 8.14 and `(lang coq (>= 0.3))` due to
  the rework of the Coq "native" compilation system (ocaml/dune#4760, @ejgallego)

- Fix a bug where instrumentation flags would be added even if the
  instrumentatation was disabled (@nojb, ocaml/dune#4770)

- Fix ocaml/dune#4682: option `-p` takes now precedence on environement variable
  `DUNE_PROFILE` (ocaml/dune#4730, ocaml/dune#4774, @bobot, reported by @dra27 ocaml/dune#4632)

- Fix installation with opam of package with dune sites. The `.install` file is
  now produced by a local `dune install` during the build phase (ocaml/dune#4730, ocaml/dune#4645,
  @bobot, reported by @kit-ty-kate ocaml/dune#4198)

- Fix multiple issues in the sites feature (ocaml/dune#4730, ocaml/dune#4645 @bobot, reported by @Lelio-Brun
  ocaml/dune#4219, by @Kakadu ocaml/dune#4325, by @toots ocaml/dune#4415)
ejgallego added a commit to ejgallego/opam-repository that referenced this issue Jul 1, 2021
…ator, dune-private-libs, dune and dune-build-info (2.9.0)

CHANGES:

- Add `(enabled_if ...)` to `(mdx ...)` (ocaml/dune#4434, @emillon)

- Add support for instrumentation dependencies (ocaml/dune#4210, fixes ocaml/dune#3983, @nojb)

- Add the possibility to use `locks` with the cram tests stanza (ocaml/dune#4480, @voodoos)

- Allow to set up merlin in a variant of the default context
  (ocaml/dune#4145, @TheLortex, @voodoos)

- Add `(package ...)` to `(mdx ...)` (ocaml/dune#4691, fixes ocaml/dune#3756, @emillon)

- Handle renaming of `coq.kernel` library to `coq-core.kernel` in Coq 8.14 (ocaml/dune#4713, @proux01)

- Fix generation of merlin configuration when using `(include_subdirs
  unqualified)` on Windows (ocaml/dune#4745, @nojb)

- Fix bug for the install of Coq native files when using `(include_subdirs qualified)`
  (ocaml/dune#4753, @ejgallego)

- Allow users to specify install target directories for `doc` and
  `etc` sections. We add new options `--docdir` and `--etcdir` to both
  Dune's configure and `dune install` command. (ocaml/dune#4744, fixes ocaml/dune#4723,
  @ejgallego, thanks to @JasonGross for reporting this issue)

- Fix issue where Dune would ignore `(env ... (coq (flags ...)))`
  declarations appearing in `dune` files (ocaml/dune#4749, fixes ocaml/dune#4566, @ejgallego @rgrinberg)

- Disable some warnings on Coq 8.14 and `(lang coq (>= 0.3))` due to
  the rework of the Coq "native" compilation system (ocaml/dune#4760, @ejgallego)

- Fix a bug where instrumentation flags would be added even if the
  instrumentatation was disabled (@nojb, ocaml/dune#4770)

- Fix ocaml/dune#4682: option `-p` takes now precedence on environement variable
  `DUNE_PROFILE` (ocaml/dune#4730, ocaml/dune#4774, @bobot, reported by @dra27 ocaml/dune#4632)

- Fix installation with opam of package with dune sites. The `.install` file is
  now produced by a local `dune install` during the build phase (ocaml/dune#4730, ocaml/dune#4645,
  @bobot, reported by @kit-ty-kate ocaml/dune#4198)

- Fix multiple issues in the sites feature (ocaml/dune#4730, ocaml/dune#4645 @bobot, reported by @Lelio-Brun
  ocaml/dune#4219, by @Kakadu ocaml/dune#4325, by @toots ocaml/dune#4415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants