Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test error cases of OSL and predicate langugae #10226

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

gridbugs
Copy link
Collaborator

@gridbugs gridbugs commented Mar 7, 2024

No description provided.

@gridbugs gridbugs requested a review from rgrinberg March 7, 2024 04:06
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add descriptions to the tests? A couple of sentences per test is fine.

@gridbugs gridbugs force-pushed the osl-and-predicate-lang-error-test branch from 8557948 to 190e275 Compare March 8, 2024 06:37
Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@gridbugs gridbugs force-pushed the osl-and-predicate-lang-error-test branch from 190e275 to 89d9e19 Compare March 8, 2024 06:37
@gridbugs gridbugs merged commit 1f80426 into ocaml:main Mar 8, 2024
1 of 2 checks passed
@gridbugs gridbugs deleted the osl-and-predicate-lang-error-test branch March 8, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants