Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repro for gh10234 #10235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add repro for gh10234 #10235

wants to merge 1 commit into from

Conversation

gridbugs
Copy link
Collaborator

@gridbugs gridbugs commented Mar 8, 2024

Adds repro test for #10234

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@rgrinberg
Copy link
Member

This should be same as #9700 as well - but on the lock file generation side. We're currently generating file://, but it's buggy. So we need to make it robust like copy.

@gridbugs
Copy link
Collaborator Author

I don't understand how this can be fixed by removing the copy constructor. The issue here is that out of date build commands are being run from the lockfile. We would need a way of checking if the opam file in the pinned package had changed and regenerating its lockfile if necessary, or a way of running the build commands from the pinned package's opam file directly rather than from its lockfile.

@rgrinberg
Copy link
Member

Good point. Why are we even recording the build command for pins again? If we have the checksum for the source, that already fixes the build command. If we don't have the cehcksum, the build command is useless anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants