Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: (modules_without_implementation) expansion #10280

Conversation

anmonteiro
Copy link
Collaborator

  • a bit of a follow-up to Allow expansion in (modules) field #9578, testing that (modules_without_implementation) is also expanded
  • I needed this for (modules_without_implementation) so I decided to write a failing test. I was pleasantly surprised that it already worked!

@anmonteiro anmonteiro force-pushed the anmonteiro/test-modules-without-implementation-expansion branch from 328f621 to 5a4fa8e Compare March 17, 2024 22:51
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/test-modules-without-implementation-expansion branch from 5a4fa8e to 5f0ce57 Compare March 17, 2024 22:56
Copy link
Collaborator

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nojb nojb merged commit f271143 into ocaml:main Mar 18, 2024
27 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/test-modules-without-implementation-expansion branch March 18, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants