refactor(pkg): remove some result monad in favor of exceptions #10577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A whole bunch of Result.* functions can now be removed and the old behavior is implemented with a try/catch Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 0b1cab0f-4401-4693-9384-4bb9b1d5dfc9 -->
rgrinberg
force-pushed
the
ps/rr/refactor_pkg___remove_some_result_monad_in_favor_of_exceptions
branch
from
70487c6
to
b884cf0
Compare
rgrinberg
deleted the
ps/rr/refactor_pkg___remove_some_result_monad_in_favor_of_exceptions
branch
MA0010
pushed a commit
to MA0010/dune
that referenced
this pull request
Aug 5, 2024
…#10577) A whole bunch of Result.* functions can now be removed and the old behavior is implemented with a try/catch Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A whole bunch of Result.* functions can now be removed and the old behavior is implemented with a try/catch
Signed-off-by: Rudi Grinberg me@rgrinberg.com