-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encourage adding email in author & maintainer info #10848
Merged
Leonidas-from-XIV
merged 1 commit into
ocaml:main
from
punchagan:author-maintainer-email
Aug 28, 2024
Merged
Encourage adding email in author & maintainer info #10848
Leonidas-from-XIV
merged 1 commit into
ocaml:main
from
punchagan:author-maintainer-email
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense and gives people a template to add their email.
For packages submitted to the opam-repository, it would help to have the email addresses of the maintainers. See ocaml/infrastructure#152. This commit subtly encourages package authors/maintainers to do so. Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
Leonidas-from-XIV
force-pushed
the
author-maintainer-email
branch
from
August 28, 2024 09:05
d7920fc
to
ceb27ef
Compare
You should add a CHANGES entry for this |
Sure, I'll do as part of #10849 |
Please add it as separate PR. |
punchagan
added a commit
to punchagan/dune
that referenced
this pull request
Aug 28, 2024
punchagan
added a commit
to punchagan/dune
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
Leonidas-from-XIV
pushed a commit
to punchagan/dune
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
Leonidas-from-XIV
pushed a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For packages submitted to the opam-repository, it would help to have the email addresses of the maintainers. See ocaml/infrastructure#152. This commit subtly encourages package authors/maintainers to do so.