Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage adding email in author & maintainer info #10848

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

punchagan
Copy link
Contributor

For packages submitted to the opam-repository, it would help to have the email addresses of the maintainers. See ocaml/infrastructure#152. This commit subtly encourages package authors/maintainers to do so.

Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense and gives people a template to add their email.

For packages submitted to the opam-repository, it would help to have the
email addresses of the maintainers. See ocaml/infrastructure#152. This
commit subtly encourages package authors/maintainers to do so.

Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
@Leonidas-from-XIV Leonidas-from-XIV merged commit beea68f into ocaml:main Aug 28, 2024
27 of 28 checks passed
@rgrinberg
Copy link
Member

You should add a CHANGES entry for this

@punchagan
Copy link
Contributor Author

Sure, I'll do as part of #10849

@punchagan punchagan deleted the author-maintainer-email branch August 28, 2024 09:52
@Leonidas-from-XIV
Copy link
Collaborator

Please add it as separate PR.

punchagan added a commit to punchagan/dune that referenced this pull request Aug 28, 2024
punchagan added a commit to punchagan/dune that referenced this pull request Aug 28, 2024
Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
@punchagan
Copy link
Contributor Author

#10854

Leonidas-from-XIV pushed a commit to punchagan/dune that referenced this pull request Aug 28, 2024
Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
Leonidas-from-XIV pushed a commit that referenced this pull request Aug 28, 2024
Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants