Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically install executable with extension .exe on Windows #123

Merged
5 commits merged into from
Jun 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 5, 2017

When the user installs an executable, if the source file ends with .bc or .exe, jbuilder makes sure that the destination ends with .exe. This way executables that are installed in any section are correctly installed with the .exe suffix.

Additionally, Jbuilder now resolves ${libexec:<foo>:<file>} to <foo dir>/<file>.exe if it exists, and <foo dir>/<file> otherwise.

@dra27, can you test this branch?

@ghost ghost added this to the 1.0.0 milestone Jun 5, 2017
@dra27
Copy link
Member

dra27 commented Jun 7, 2017

This is great, thanks - I haven't got anything quickly with which to test the ${libexec:...} part, but the automatic adding of .exe is definitely working for ocamlopt compiled and also for a toploop installed using an install stanza.

@dra27
Copy link
Member

dra27 commented Jun 8, 2017

This is good to go for me - happy to merge?

@ghost
Copy link
Author

ghost commented Jun 8, 2017

yep

@ghost ghost merged commit 2e2a707 into master Jun 8, 2017
@fdopen
Copy link

fdopen commented Jun 22, 2017

There seems to be something wrong with this commit. The latest js_of_ocaml doesn't compile since this commit:
Multiple rules generated for _build/install/default/bin/jsoo_link.exe

@hhugo
Copy link
Collaborator

hhugo commented Jun 22, 2017

js_of_ocaml install these explicitly
https://github.com/ocsigen/js_of_ocaml/blob/master/compiler/jbuild#L35

@ghost
Copy link
Author

ghost commented Jun 26, 2017

@hhugo, do you install both the version with the .exe suffix and the one without?

@dbuenzli
Copy link

dbuenzli commented Aug 8, 2017

I guess it does not, see dbuenzli/vg#16

@ghost ghost deleted the auto-exe-ext branch February 7, 2018 14:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants