Fix generation of melrin with equal ppx pp #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rgrinberg
force-pushed
the
fix-merlin-with-equal-pp
branch
2 times, most recently
from
50169ba
to
ef04d67
Compare
ghost
approved these changes
May 29, 2019
rgrinberg
force-pushed
the
fix-merlin-with-equal-pp
branch
from
ef04d67
to
59ab99a
Compare
Previously, if the pps were all ppx and equivalent, then they would be dropped. Fix ocaml#2206 Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
rgrinberg
force-pushed
the
fix-merlin-with-equal-pp
branch
from
59ab99a
to
896898f
Compare
jberdine
reviewed
May 30, 2019
| @@ -84,6 +84,9 @@ unreleased | |||
| would be undetected whenever the project was nested in another workspace. | |||
| (#2194, @rgrinberg) | |||
|
|
|||
| - Fix generation of `.merlin` whenever there's more than one stanza with the | |||
| same ppx preprocessing specification (#2209 ,fixes #2206, @rgrinberg) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the pps were all ppx and equivalent, then they would
be dropped.
Fix #2206