Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binary operators in package description #2963

Merged
2 commits merged into from Dec 12, 2019
Merged

Support binary operators in package description #2963

2 commits merged into from Dec 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2019

Add support for writing (depends (conf-x11 (<> os win32))). Currently, <> can only be used as a unary operator.

@ghost ghost mentioned this pull request Dec 11, 2019
@ghost
Copy link
Author

ghost commented Dec 11, 2019

Ah, I just realised that (<> xxx) means "version of dep is different from xxx". So in fact it's not a bug, we just need to extend the syntax.

@ghost ghost changed the title [WIP] Support binary operators in package description Support binary operators in package description Dec 12, 2019
@ghost
Copy link
Author

ghost commented Dec 12, 2019

This is ready for review.

@ghost ghost requested a review from rgrinberg December 12, 2019 12:56
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
@ghost ghost merged commit 72a82e7 into ocaml:master Dec 12, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants