Improve library redirect behavior #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a follow up to #3729 |
|
Yes, this PR does not address #3729 because that issue has already been fully resolved. It's just that I later realized I can maintain all the redirection mechanisms in a single place. Previously, it was split across Scope and Dune_file. |
rgrinberg
force-pushed
the
improve-private-lib-redirect
branch
from
5e87ea1
to
222f3d3
Compare
Apologies I meant #3810, but I was confused, I see that this PR is not related to that one. |
|
I’m not entirely sure how to fix #3810 yet unfortunately :/
Rudi.
…On Sep 22, 2020, 7:40 PM -0700, Nicolás Ojeda Bär ***@***.***>, wrote:
> Yes, this PR does not address #3729 because that issue has already been fully resolved. It's just that I later realized I can maintain all the redirection mechanisms in a single place. Previously, it was split across Scope and Dune_file.
Apologies I meant #3810, but I was confused, I see that this PR is not related to that one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
bobot
reviewed
Sep 23, 2020
rgrinberg
force-pushed
the
improve-private-lib-redirect
branch
from
222f3d3
to
ccbe80b
Compare
Previously, we'd add redirect for private libraries only if the underlying libraries were filtered out. It's simpler, to just always add a redirect and rmeove the additional logic for redirects when constructing a library database. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
improve-private-lib-redirect
branch
from
ccbe80b
to
2f3e821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd add redirect for private libraries only if the
underlying libraries were filtered out. It's simpler, to just always add
a redirect and rmeove the additional logic for redirects when
constructing a library database.