-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: add support for ocamldoc pseudo-package #4811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
@talex5 if you want to give this one a try, I created a branch with the fix backported to 2.9 (the last released version of |
Thanks! This fixes the problem for me. |
Great, thanks for the confirmation. |
Worth to ship maybe in 2.9.1 @nojb ? |
Indeed, I was going to bring it up :) |
ejgallego
pushed a commit
to ejgallego/dune
that referenced
this pull request
Sep 7, 2021
Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Sep 7, 2021
…ator, dune-private-libs, dune and dune-build-info (2.9.1) CHANGES: - Don't use `subst --root` in Opam files (ocaml/dune#4806, @MisterDA) - Fix compilation on Haiku (ocaml/dune#4885, @Sylvain78) - Allow depending on `ocamldoc` library when `ocamlfind` is not installed. (ocaml/dune#4811, fixes ocaml/dune#4809, @nojb) - Fix `(enabled_if ...)` for installed libraries (ocaml/dune#4824, fixes ocaml/dune#4821, @dra27) - Create more future-proof opam files using `--promote-install-files=false` (ocaml/dune#4860, @bobot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4809
cc @talex5