Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about monorepo benchmark to hacking doc #7361

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

gridbugs
Copy link
Collaborator

No description provided.

doc/hacking.rst Outdated Show resolved Hide resolved
doc/hacking.rst Outdated Show resolved Hide resolved
doc/hacking.rst Outdated Show resolved Hide resolved
@Alizter
Copy link
Collaborator

Alizter commented Mar 22, 2023

I think some more details are needed about which docker commands to run after building the image.

I got as far as to build the image and run:

$ docker run name_of_image

then I go to bench/monorepo however the first issue is that dune is required, not the bootstrapped one:

$ make bench
dune build _build/default/bench.exe --release
make: dune: No such file or directory
make: *** [Makefile:6: _build/default/bench.exe] Error 127

putting some dune into the environment allows me to continue but now:

$ make bench
dune build _build/default/bench.exe --release
_build/default/bench.exe /home/user/dune/_build/default/bin/main.exe build -j auto
Fatal error: exception Unix.Unix_error(Unix.ENOENT, "create_process", "/home/user/dune/_build/default/bin/main.exe")
make: *** [Makefile:9: bench] Error 2

Not sure how to proceed form here.

Also the docker image is not named after being built and I had to explicitly docker tag it.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
This prevents incompatible artifacts inside a _build directory from
making their way into the docker image.

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
@gridbugs
Copy link
Collaborator Author

I fixed an issue with the benchmarks where if a _build directory was present inside bench/monorepo make bench would fail. This was the problem @Alizter ran into above.

I've also added the full docker commands I use to build and run the image.

@Alizter Alizter merged commit 86623eb into ocaml:main Mar 22, 2023
@gridbugs gridbugs deleted the monorepo-bench-hacking-doc branch October 11, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants