Fix problem with setting page permission during relocation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another take at #57, avoiding repeated calls to VirtualProtect on the same pages for performance reasons.
|
Looks good! |
|
Following this PR, one could avoid computing those 'nonwr' stuff. Cf 47e7180 This breaks compatibility between versions of flexdll, for very little gain. So perhaps it's not worth doing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take at #57, avoiding repeated calls to VirtualProtect on the same pages for performance reasons.
Loading the big .cmxs I mentioned in #57 now takes about 0.22s (against 0.20s before the change, and against 0.65s with the version in #57). One could try to be even more clever and group relocation that fall in adjacent pages, but this becomes a bit more tricky.