Correct the parsing of /n COFF lib headers #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COFF defines any archive header beginning with / as special. Before, we assumed that if the header was neither / nor // then it must be /n and parsed accordingly. That breaks with the new /<XFGHASH>/ header. Harden the parsing code to allow these new header to be correctly skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COFF defines any archive header beginning with
/as special. Before, we assumed that if the header was neither/nor//then it must be/nand parsed accordingly. That breaks with the new/<XFGHASH>/header in the Windows 11 SDK.The fact the new header begins with
/means it should not just be interpreted as an object - the solution I've gone with here is to harden the parsing of/nto ignore headers wherenis not a positive decimal integer.