Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 4.09.0 #11

Merged
1 commit merged into from
Aug 6, 2019
Merged

Prepare for 4.09.0 #11

1 commit merged into from
Aug 6, 2019

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Aug 1, 2019

I have:

  • Put a version field in dune-project (I think that may be unnecessary once it's tagged??)
  • Synchronised graphics.opam with the versions in opam-repository
  • Tweaked the META file slightly

This seems to be working on 4.09.0 beta1 for me

@ghost
Copy link

ghost commented Aug 5, 2019

Thanks :) For the version in dune-project, no it's not necessary. It's automatically added by dune-release. When dev-pinned, dune install automatically adds the version to the META and opam files.

dune-project Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 5, 2019

BTW, I have you commit rights on the repo.

@dra27
Copy link
Member Author

dra27 commented Aug 6, 2019

Thanks, @diml! version removed from dune-project, so this is good to go.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ghost
Copy link

ghost commented Aug 6, 2019

No problem :) Merging now

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant