Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit updated setup.ml in oasis before tagging a release #121

Open
gildor478 opened this issue Dec 20, 2017 · 0 comments
Open

Commit updated setup.ml in oasis before tagging a release #121

gildor478 opened this issue Dec 20, 2017 · 0 comments

Comments

@gildor478
Copy link
Member

Right now, the tag is set independently of the generated tarball. The oasis project has actually a significant difference in its setup.ml, because we store the generated version in the VCS.

We should change the order to generation to have:

  1. start a release
  2. build oasis
  3. use built oasis to generate setup.ml
  4. generate the tarball
  5. tag a release

The content of the release tarball will be closer to the content of the VCS for the release tag.

See #107 for someone affected by this discrepancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant