-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line editing for Pointers #1112
Conversation
Co-authored-by: sabine <sabine@users.noreply.github.com>
Co-authored-by: sabine <sabine@users.noreply.github.com>
Excellent suggestions, @sabine! I've committed them to the file. |
Great! Now that you both have looked over it, is it ready to merge? (@cuihtlauac & @sabine) |
Yes, we can merge that, but reading the overall tutorial, I think this requires some deeper editing and restructuring than just line editing. It's the same situation as we have in many of the other tutorials. |
Good to know @sabine. What can I do to help with that? |
The main problem with these tutorials is that they target a very specific kind of user - and there is no consistency on the previous knowledge the tutorials require. In this tutorial, the targeted user is apparently someone who knows pointers because they know the C programming language. |
Do you have some suggestions on how to make it more consistent? I would be more than happy to work on that. Also, would it be helpful to write an introduction to Pointers? |
This tutorial needs a serious rewrite. I don't even think using the term “pointer” makes any sense at all in the context of OCaml. However, this is not a rewrite likely to happen in a short time. In the meantime, it's always better to improve what's possible, that will always be helpful for a more in-depth rewrite. |
Agreed. It's good to start somewhere, and we can keep improving iteratively! 😄 |
Shall we merge this one for now until the indepth rewrite @cuihtlauac & @sabine |
@christinerose Indeed, it is merged. |
Oh Great! Thank you! |
No description provided.