Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turned exercise 036 into practice #2223

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Turned exercise 036 into practice #2223

merged 1 commit into from
Mar 15, 2024

Conversation

divyankachaudhari
Copy link
Contributor

Addresses #2200. Turns Exercise 036 into practice.

dune build --root . and dune test --root . answer work.

Added two extra test cases:

  • Prime factors with multiplicities of 1
  • Prime factors with multiplicities of a prime number

@divyankachaudhari divyankachaudhari marked this pull request as draft March 15, 2024 07:08
@divyankachaudhari divyankachaudhari marked this pull request as ready for review March 15, 2024 07:26
cuihtlauac
cuihtlauac approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks @divyankachaudhari

@cuihtlauac cuihtlauac merged commit 6462cc4 into ocaml:main Mar 15, 2024
3 checks passed
@cuihtlauac cuihtlauac mentioned this pull request Mar 18, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuihtlauac cuihtlauac cuihtlauac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyankachaudhari @cuihtlauac