Dune 3.15.0 announcement #2316
Merged
Dune 3.15.0 announcement #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillon
reviewed
Apr 3, 2024
emillon
reviewed
Apr 3, 2024
Comment on lines
99
to
101
| Dune's own files are assumed to be UTF-8 encoded, yet the formatter would err | ||
| on the safe side and escape bytes outside the ASCII range, even if the files | ||
| were valid UTF-8 sequences. |
There was a problem hiding this comment.
I don't think that it's completely accurate. We didn't assume anything about the encoding of dune files (similarly to what the compiler does). What changed is that if the parsed value is valid utf8, we output a utf8-encoded dune file.
There was a problem hiding this comment.
I've rewritten this. Can you take a look if this is a better representation of the issue?
emillon
reviewed
Apr 3, 2024
Leonidas-from-XIV
force-pushed
the
dune-3.15.0
branch
from
3707616
to
8dcfac7
Compare
22 tasks
emillon
approved these changes
Apr 5, 2024
cuihtlauac
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.