-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated functions #10867
Remove deprecated functions #10867
Conversation
26b471d
to
187a426
Compare
187a426
to
c818e91
Compare
c818e91
to
3aa6e7f
Compare
For the
It's probably better to fix these separately from this PR, but worth a followup issue to not forget? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, planning to merge by end of day unless someone objects. |
Thanks @avsm, will make a new issue with your note once the PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through all these and it looks good to me as well.
I have some doubts about the tag-related function in |
Thanks for chiming in @Octachron! Sorry if I missed something, but are you suggesting any changes to the present PR, or was your comment just to float the idea of a compatibility library? I never use such libraries myself, but I don't have any objections to having one either :) |
Sorry, I meant to say that the deprecated string tag functions might have still have some active users in the wild: the deprecation is relatively recent (only 3 years) and the new API can be slightly more cumbersome in very specific cases. Thus I expect that this specific change will break some existing code somewhere. However, since those deprecated functions can be easily implemented in a library, the simplest choice seems to offer a compatibility library for people that don't or can't move to the new semantic tags. In short, I am offering to write a compatibility library without changing anything in this PR (beyond keeping a record in this very discussion that those functions might require a compatibility library). |
This reverts commit 2526e22.
Note: some code breakage due to the removal of the Format string-tag API is being discussed in #10917. |
This PR proposes removing a bunch of deprecated functions in the 5.0 release.