Github Actions: Move manual changes logic earlier in the build process #11470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ances of not losing references to the PR changes if merged early.
dra27
added a commit
that referenced
this pull request
Aug 2, 2022
Github Actions: Move manual changes logic earlier in the build process (cherry picked from commit 420e9c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses @xavierleroy grievances where it is possible for a manual build to fail if a PR is merged before all the checks have been completed.
@dra27 analysis suggests that this is related to the PR being closed and the reference being lost causes the logic in the detection script to fail.
As such, moving the detection to be one of the first steps the
Buildworkflow does reduces tremendously the chances of such things to happen.