-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for flambda's optimization options to OCamlbuild #68
Conversation
Does your choice of documentation parameter reflect the current default values? Will we want to keep them in sync' in the future? |
The patch is fine as far as I'm concerned, I'll merge it later if there is no other comments. Just, could you cut the lines above 80 columns? (One certainly is, I can't browse it in the github diff, I suspect some of the |
Yes, the default values correspond to those documented here. |
While you're at it, you should also add a |
49852d7
to
a5522fe
Compare
Did the changes and rebased into a single commit. |
The Changes option should go in the next section. I'll cleanup myself (I've been nitpicky enough already), add an information on option naming in the Changes entry (it also serves as user documentation), and update the manual. Thanks! |
Used defaults as per ocaml/ocamlbuild#68 . Please check if this makes sense, I did not test or verufy.
in a little section; defaults for the values were copied from ocaml#68 .
Add support for the new optimization command line options brought by flambda.
The OCamlbuild flags are named according to the flambda options with two exceptions (to clarify the meaning of the flag):
-rounds <int>
can be specified with theoptimization_rounds(int)
flag-O{2,3,classic}
can be specified with theoptimize({2,3,classic})
flag