Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to shape lookup of missing items #1078

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix to shape lookup of missing items #1078

merged 1 commit into from
Feb 12, 2024

Conversation

jonludlam
Copy link
Member

Looking up non-existent things in shapes takes ages - don't do it!

@jonludlam jonludlam added the no changelog This pull request does not need a changelog entry label Feb 8, 2024
@jonludlam
Copy link
Member Author

I don't think this needs a changelog.

@jonludlam jonludlam mentioned this pull request Feb 8, 2024
Merged
panglesd
panglesd approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@panglesd panglesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find a case where we want to lookup the shape of an internal identifier, so this looks good to me, and is a nice performance improvement (for some reasons)!

@jonludlam jonludlam merged commit 2ea454b into ocaml:master Feb 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panglesd panglesd panglesd approved these changes

Assignees
No one assigned
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonludlam @panglesd