Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test nested HTML pages #266

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Test nested HTML pages #266

merged 1 commit into from
Dec 10, 2018

Conversation

rizo
Copy link
Collaborator

@rizo rizo commented Dec 6, 2018

Attempts to fix #213.

I plan to split the work in two parts:

  • Adapt the runner to diff multiple outputs per test case.
  • Add, review and promote actual HTML files. (see comments below)

Maybe it's better to split the second point in multiple commits to make review easier.

@rizo rizo requested a review from aantron December 6, 2018 23:49
@rizo rizo changed the title Adapt the HTML test runner to diff multiple outputs per test case. Test nested HTML pages Dec 6, 2018
@rizo rizo changed the title Test nested HTML pages [WIP] Test nested HTML pages Dec 6, 2018
@aantron
Copy link
Contributor

aantron commented Dec 7, 2018

Thanks, I'll take a close look tomorrow!

I recommend adding a minimum of extra files, i.e. omitting as much of the list in #213 as possible.

Copy link
Contributor

@aantron aantron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

@aantron
Copy link
Contributor

aantron commented Dec 10, 2018

I suggest doing the second part as part of #261. We don't need to test every nested page. Many are generated as unneeded side effects of having dummy modules, for example. We just need to test nested pages in those tests where a useful feature is exercised, such as one page for #261.

@aantron
Copy link
Contributor

aantron commented Dec 10, 2018

(...which means I think this is ready for merge so that #261 can be rebased over it, let me know if you agree)

@rizo rizo changed the title [WIP] Test nested HTML pages Test nested HTML pages Dec 10, 2018
@rizo
Copy link
Collaborator Author

rizo commented Dec 10, 2018

I agree @aantron, thanks for the review. Let's merge this and rebase #261.

I would suggest only closing #213 when we decide what other nested pages should be tested.

@aantron aantron merged commit 25a401c into ocaml:master Dec 10, 2018
@aantron
Copy link
Contributor

aantron commented Dec 10, 2018

Thanks! #213 is still open after this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants